Module:Formatnum is permanently protected from editing because it is a heavily used or highly visible module. Substantial changes should be proposed here first. If the proposal is uncontroversial or has been discussed and is supported by consensus, editors may use ((edit template-protected)) to notify an administrator or template editor to make the requested edit.
|
This module was considered for deletion on 2018 September 21. The result of the discussion was "keep". |
If I read the code correctly, then tonumber(number)
is already computed and stored in the variable named “value”. Incnis Mrsi (talk) 09:55, 22 October 2019 (UTC)
mw.language:formatNum()
call doesn't handle exponents properly. The lines 41 to 52 convert number to a string, then if there is an exponent, it stores the significand as a string back into number and the exponent in exponent. So by the time the code reaches lines 84 or 86 the string value in number may or may not be the same as that passed into the function. So it's necessary to again convert that string back to a number in order to use mw.language:formatNum()
. Writing language:formatNum(value, ...)
wouldn't work properly if the number passed contained an exponent. Hope that makes sense. --RexxS (talk) 16:18, 22 October 2019 (UTC)
number = string.sub(number, 1, pos - 1)
. Incnis Mrsi (talk) 17:11, 22 October 2019 (UTC)If I use fn.formatNum(5435.12345,"en",2)
I get the result 5,435.12
as expected. Similarly with other positive values for precision. But with fn.formatNum(5435.12345,"en",0)
the number is returned with all the post decimal point digits, i.e. 5,435.12345
). Looking at the code there are a couple of if prec > 0 then ... elseif prec < 0 then .. end
blocks which suggests zero is ignored. Is this intentional or an oversight? Jts1882 | talk 15:35, 9 December 2019 (UTC)
This edit request has been answered. Set the |answered= or |ans= parameter to no to reactivate your request. |
The production code cannot be #invoke'd normally, only wrapped by templates. The sandbox code fixes this. Trigenibinion (talk) 11:56, 3 March 2021 (UTC)
((edit template-protected))
template. It is not obvious to me that it would be beneficial to allow a module-version to be used. What is the proposed use case where it is necessary? (See also Template talk:Infobox for a related case.) Izno (talk) 02:11, 5 June 2021 (UTC)