The following discussion is an archived debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA. The result of the discussion was  Approved.

WikiCleanerBot 5

[edit]

Operator: NicoV (talk · contribs · SUL · edit count · logs · page moves · block log · rights log · ANI search)

Time filed: 08:49, Saturday, June 15, 2019 (UTC)

Function overview: Fix some WP:WCW errors using WPCleaner

Automatic, Supervised, or Manual: Automatic

Programming language(s): Java (WPCleaner)

Source code available: On GitHub

Links to relevant discussions (where appropriate): Wikipedia:Bots/Requests for approval/PkbwcgsBot

Edit period(s): Twice a month, with the dump analysis that I already perform, see Wikipedia:Bots/Requests for approval/WikiCleanerBot.

Estimated number of pages affected: A few thousand articles for the initial runs spread over a few sessions, then normally only a few dozen or hundreds each time.

Namespace(s): Main

Exclusion compliant (Yes/No): Yes

Function details: As PkbwcgsBot hasn't been run for several months, I'd like to take over some of the tasks that Pkbwcgs was performing with WPCleaner. This request is a part of Wikipedia:Bots/Requests for approval/PkbwcgsBot. It includes automatically fixing part of some WP:WCW errors:

Discussion

[edit]

Approved for trial (140 edits). Please provide a link to the relevant contributions and/or diffs when the trial is complete. Please run 20 edits for each proposed task. Primefac (talk) 12:31, 15 June 2019 (UTC)[reply]

Thanks ! Here are the results:
Trial complete.. --NicoV (Talk on frwiki) 14:17, 15 June 2019 (UTC)[reply]
((BAG assistance needed)) --NicoV (Talk on frwiki) 13:57, 25 July 2019 (UTC)[reply]
@NicoV: Approved for extended trial. Please provide a link to the relevant contributions and/or diffs when the trial is complete. 20 edits each for CW Error #85 and CW Error #91. Headbomb {t · c · p · b} 04:07, 6 August 2019 (UTC)[reply]
Thanks Headbomb. Here are the results:
Trial complete. --NicoV (Talk on frwiki) 20:48, 6 August 2019 (UTC)[reply]
@NicoV: This would be much better than this. Headbomb {t · c · p · b} 21:01, 6 August 2019 (UTC)[reply]
@Headbomb: I can also remove the carriage return if the empty tag was on the first line, and alone in the line, if you want. For other cases (not on the first line), there may be side effects with removing the carriage return. What do you say? --NicoV (Talk on frwiki) 21:22, 6 August 2019 (UTC)[reply]
Should be for otherwise empty lines only. Headbomb {t · c · p · b} 21:34, 6 August 2019 (UTC)[reply]
@Headbomb: The problem is that it will change the display in some situations, see below. --NicoV (Talk on frwiki) 22:53, 6 August 2019 (UTC)[reply]
@Headbomb: I've modified WPC to remove extra white lines (if there are 2 or more, or if they are the beginning or the end of the article). Result on the same article that you reported. --NicoV (Talk on frwiki) 19:32, 7 August 2019 (UTC)[reply]

Example: 

Line 1 before noinclude tag
<noinclude></noinclude>
Line 2 after noinclude tag

Before removal of the empty tag:

Line 1 before noinclude tag

Line 2 after noinclude tag

After removal of the empty tag (keeping the empty line): same display

Line 1 before noinclude tag

Line 2 after noinclude tag

After removal of the empty tag (removing the empty line): modified display

Line 1 before noinclude tag Line 2 after noinclude tag

Approved for extended trial. Please provide a link to the relevant contributions and/or diffs when the trial is complete. 20 edits to see if that case is handled correctly in, and results in oddities otherwise. Have a mix of that case and others in the trial if possible. Headbomb {t · c · p · b} 20:10, 7 August 2019 (UTC)[reply]
@Headbomb: Here are the new edits:
  1. Feminism in Sweden: span tags in the middle of a sentence
  2. FK Dubnica: gallery tags in their own lines
  3. FC Epfendorf 1929: center tags in table cells
  4. Eretz Yisrael Shelanu: div tags at the end of table
  5. Elsa Cladera de Bravo: includeonly tags in the middle of a sentence
  6. Dominic Fotia: gallery tags at the beginning of the article
  7. Domadugu: div tags on their own lines
  8. District of Columbia and United States Territories Quarter: noinclude tags at the beginning of the article
  9. History of agriculture: div tags spanning on 2 lines
  10. Hidden message: includeonly tags in the middle of a sentence
  11. Heritage Day (South Africa): includeonly tags in the middle of a sentence
  12. Heidi Quante: gallery tags spanning on 2 lines
  13. H. M. Khoja: gallery tags spanning on 2 lines
  14. God's Favorite Customer: includeonly tags at the beginning of the article
  15. Geneva fusillade of 9 November 1932: span tags in the middle of a sentence
  16. Fredericton shooting: includeonly tags at the beginning of a sentence
  17. Frank Dorsa: gallery tags at the beginning of the article
  18. Jacques Delors: includeonly tags at the beginning of the article
  19. Jakobstad Museum: gallery tags at the end of the article
  20. Isleworth Mona Lisa: includeonly tags at the beginning of the article
Trial complete. --NicoV (Talk on frwiki) 21:29, 7 August 2019 (UTC)[reply]

 Approved. CW Error #85 is technically cosmetic in many cases, but I feel it's editor-hostile enough to deal with it through a bot. Ping me if there's pushback on that task. Headbomb {t · c · p · b} 22:12, 7 August 2019 (UTC)[reply]

The above discussion is preserved as an archive of the debate. Please do not modify it. To request review of this BRFA, please start a new section at WT:BRFA.
Category